Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public underpinings for Hyper-V snapshots - take 2 #3214

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Aug 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3214 (800547f) into snapshots (08fa9d4) will decrease coverage by 0.01%.
Report is 384 commits behind head on snapshots.
The diff coverage is 47.29%.

@@              Coverage Diff              @@
##           snapshots    #3214      +/-   ##
=============================================
- Coverage      84.62%   84.61%   -0.01%     
=============================================
  Files            247      247              
  Lines          13102    13107       +5     
=============================================
+ Hits           11088    11091       +3     
- Misses          2014     2016       +2     
Files Changed Coverage Δ
include/multipass/exceptions/snapshot_exceptions.h 0.00% <0.00%> (ø)
include/multipass/virtual_machine.h 100.00% <ø> (ø)
include/multipass/vm_mount.h 44.44% <0.00%> (ø)
src/client/cli/cmd/delete.h 100.00% <ø> (ø)
src/daemon/daemon.h 100.00% <ø> (ø)
src/daemon/daemon_rpc.cpp 87.87% <0.00%> (ø)
src/daemon/vm_specs.h 57.14% <0.00%> (ø)
src/iso/cloud_init_iso.cpp 98.98% <0.00%> (-0.51%) ⬇️
...tform/backends/libvirt/libvirt_virtual_machine.cpp 62.88% <0.00%> (ø)
src/platform/backends/lxd/lxd_mount_handler.h 0.00% <ø> (ø)
... and 36 more

ricab added 2 commits August 29, 2023 18:40
Move snapshot name template and derivation to the BaseSnapshot, in order
to reuse in other backends.
Rename method to derive the ID of a snapshot, to use with the backend
("tag" was a QEMU concept).
@ricab
Copy link
Collaborator Author

ricab commented Sep 14, 2023

Oops, forgot to merge this side.

@ricab ricab merged commit 6c2422c into snapshots Sep 14, 2023
9 of 12 checks passed
@bors bors bot deleted the hyper-v-snapshots branch September 14, 2023 10:13
ricab added a commit that referenced this pull request Oct 25, 2023
Public underpinings for Hyper-V snapshots - take 2

r=sharder996 a=ricab
ricab added a commit that referenced this pull request Oct 30, 2023
Public underpinings for Hyper-V snapshots - take 2

r=sharder996 a=ricab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant