Code

Introduce a Stopping state#3483

Code

Draft

ricab wants to merge 49 commits intomaincanonical/multipass:mainfrom add-stopping-statecanonical/multipass:add-stopping-stateCopy head branch name to clipboard

+609-89

Commits

Commits on Apr 12, 2024

• [rpc] Add option to force stopping an instance.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  4e8fd7d

• [vm] Add bool to force shutdown.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  862802b

• [cli] Handle command.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  992cfc8

• [tests] Adapt stub and mock to new vm interface.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  f79ed51

• [daemon] Handle forced stop command

  

  luis4a0

  authored and

  Chris Townsend

  committed
  2d69854

• [tests] Use the new virtual_machine.h interface.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  ea86fea

• [qemu] Implement forced stop.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  04edcc3

• [lxd] Implement forced stop.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  c9579e7

• [libvirt] Implement forced stop.

  

  luis4a0

  authored and

  Chris Townsend

  committed
  48846e6

• refactor with main

  

  sharder996

  authored and

  Chris Townsend

  committed
  dce9c9f

• [cli/stop] Make force a long option only

  Show description for 99f9368
  

  Chris Townsend

  committed
  99f9368

• [virtual_machine] Make force shutdown bool const

  

  Chris Townsend

  committed
  3cca6db

• [tests] Fix QEMU test for setting bool for shutdown()

  

  Chris Townsend

  committed
  4450fec

• [tests/cli] Test the --force option for stop command

  

  Chris Townsend

  committed
  b73e5a0

• [tests/qemu] Add tests for the force shutdown handling

  

  Chris Townsend

  committed
  9e6737b

• Update src/platform/backends/qemu/qemu_virtual_machine.cpp

  Show description for c39895e
  

  Chris Townsend

  and

  ricab

  committed
  c39895e

• [tests] Fix tests due to change in log string

  

  Chris Townsend

  committed
  8ac8d93

Commits on Apr 15, 2024

• [vm] Add a stopping state

  ricab

  committed
  96894a8

• [daemon] Handle start while stopping

  ricab

  committed
  a189588

• [daemon] Handle reboot while stopping

  ricab

  committed
  86490ed

• [daemon] Refuse SSH info while stopping

  ricab

  committed
  5461553

• [libvirt] Recognize stopping VMs

  ricab

  committed
  291592d

• [libvirt] Prevent start while stopping

  ricab

  committed
  a8225da

• [libvirt] Ignore shutdown while stopping

  ricab

  committed
  d52683b

• [libvirt] Ignore suspend while stopping

  ricab

  committed
  fbda51f

• [lxd] Recognize stopping VMs

  ricab

  committed
  352cc58

• [lxd] Refuse to start a stopping VM

  ricab

  committed
  88d259f

• [lxd] Ignore stop if off

  ricab

  committed
  696ab5c

• [lxd] Ignore shutdown while stopping

  ricab

  committed
  fb36326

• [lxd] Drop SSH session when stopping

  Show description for 6fa15bc
  ricab

  committed
  6fa15bc

• [lxd] Handle further states when ensuring running

  Show description for c6d8d52
  ricab

  committed
  c6d8d52

• [qemu] Recognize stopping VMs

  ricab

  committed
  f8b1955

• [qemu] Handle multiple QMP entries in single read

  Show description for 046ac69
  ricab

  committed
  046ac69

• [qemu] Warn if we read outside newline boundaries

  Show description for 10ab157
  ricab

  committed
  10ab157

• [qemu] Drop SSH session when stop is detected

  ricab

  committed
  c58570c

• [qemu] Refuse to start while stopping

  ricab

  committed
  77f9b9f

• [qemu] Ignore suspend while stopping

  ricab

  committed
  ff76b49

• [daemon] Skip (ACPI) shutdown on stopping VMs

  ricab

  committed
  769c4ab

• [tests] Cover Stopping state in existing test

  ricab

  committed
  69f7862

• [test] Verify is_running on stopping state

  ricab

  committed
  9c5d246

Commits on Apr 23, 2024

• [cli] Convert stopping state to string

  ricab

  committed
  212be77

• [tests] Check str representation of STOPPING state

  ricab

  committed
  edc1195

• [tests] Add stopping instance to formatter tests

  ricab

  committed
  fcd1fb5

• [shutdown] Lock when cancelling delayed_shutdown

  ricab

  committed
  a3631ab

• [qemu] Lock and log stopping state

  ricab

  committed
  d759e58

Commits on Apr 26, 2024

• [lxd] Drive LXD instances into Stopping state

  ricab

  committed
  4faa19a

• [libvirt] Drive libvirt VMs into stopping state

  ricab

  committed
  2115048

Commits on Apr 30, 2024

• [qemu] Drive QEMU VMs into the stopping state

  ricab

  committed
  5a768d0

• [qemu] Ignore shutdown in more inapplicable states

  ricab

  committed
  89b4ab1