Redfish collector try to login and logout on each scrape

[chanchiwai-ray]

The current implementation of redfish collector is not efficient because it tries to login and logout on each scrape. Ideally, after login, we can reuse the session for subsequent calls of fetch, and if the session is expired, then we can re-login again.

[gabrielcocenza]

@chanchiwai-ray Is there any metrics showing how inefficient it is and what would be the gain?

[chanchiwai-ray]

No, I don't have the hardware to collect any metrics. From the code, it creates a connection and login and logout for each fetch, and that logically is not ideal (considering the exporter is a long-lived service), but I doubt that it has strong impact to the performance.

[aieri]

I would then close this for now. We can reopen if it seems to be a significant performance issue. Reusing the connection would add a little bit of extra complexity.