Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests with parameterized #53

Closed
dashmage opened this issue Dec 1, 2023 · 0 comments · Fixed by #55
Closed

Refactor tests with parameterized #53

dashmage opened this issue Dec 1, 2023 · 0 comments · Fixed by #55
Assignees
@dashmage
Labels
enhancement New feature or request

Comments

@dashmage
Copy link
Contributor

dashmage commented Dec 1, 2023

Refactor tests with similar inputs using the parameterized package. For eg: test_redfish.py::test_get_storage_controller_data_success and test_redfish.py::test_non_standard_storage_uri_name can be combined into one test.

Refer this commit for implementation details.
@dashmage dashmage self-assigned this Dec 1, 2023
@dashmage dashmage added the enhancement New feature or request label Dec 1, 2023
@dashmage dashmage mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashmage dashmage

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Use parameterized in redfish unit tests. dashmage/prometheus-hardware-exporter
1 participant
@dashmage