Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-462 - failing integration test ci job #463

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

a-dubs
Copy link
Collaborator

@a-dubs a-dubs commented Jan 31, 2025

Fixes #462

@a-dubs a-dubs force-pushed the GH-462-fix-integrations-ci branch 7 times, most recently from 46cf3b6 to c5c6a11 Compare February 4, 2025 20:00
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment inline, and let's get rid of the comments in ci.yaml. But otherwise looks good.

- name: Run CI integration tests
run: sg lxd -c 'tox -e integration-tests-ci'
run: |
ls -l /home/runner/.config/pycloudlib.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't needed, correct?

Copy link
Member

@mstpn mstpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pairing with me for a part of this fix, it touched a surprising amount of code!

Nit on removing a commented out block similar to @TheRealFalcons note.

@a-dubs a-dubs force-pushed the GH-462-fix-integrations-ci branch from c5c6a11 to 574d790 Compare February 5, 2025 15:57
@a-dubs a-dubs force-pushed the GH-462-fix-integrations-ci branch from 4bd7bea to ca946b0 Compare February 5, 2025 16:40
@mstpn mstpn merged commit 4153429 into canonical:main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix integration tests github action
4 participants