-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GH-462 - failing integration test ci job #463
Conversation
46cf3b6
to
c5c6a11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment inline, and let's get rid of the comments in ci.yaml
. But otherwise looks good.
.github/workflows/ci.yaml
Outdated
- name: Run CI integration tests | ||
run: sg lxd -c 'tox -e integration-tests-ci' | ||
run: | | ||
ls -l /home/runner/.config/pycloudlib.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line isn't needed, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pairing with me for a part of this fix, it touched a surprising amount of code!
Nit on removing a commented out block similar to @TheRealFalcons note.
c5c6a11
to
574d790
Compare
4bd7bea
to
ca946b0
Compare
Fixes #462