Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Event-Set interface #708

Closed
wants to merge 5 commits into from
Closed

Add Event-Set interface #708

wants to merge 5 commits into from

Conversation

yuqi88
Copy link
Contributor

@yuqi88 yuqi88 commented Aug 10, 2023 •
edited
Loading

Description

  • Added event-set interface

Types of changes

What types of changes does your code introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (only improve the code quality no change in functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Issue has been created
  • Every file touched is linted
  • Every file touched has tests that cover all the funcitonality with green coverage
  • Documentation is updated (if applicable).

Issue

closes #705

Tests

Screenshots (if appropriate):

@yuqi88 yuqi88 self-assigned this Aug 10, 2023
@yuqi88 yuqi88 marked this pull request as draft August 10, 2023 22:16
@yuqi88 yuqi88 changed the title Added Event-Set interface Add Event-Set interface Aug 11, 2023
@yuqi88 yuqi88 mentioned this pull request Aug 11, 2023
Closed
8 tasks
@yuqi88 yuqi88 marked this pull request as ready for review September 29, 2023 01:58
Opeyem1a
Opeyem1a approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@Opeyem1a Opeyem1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me - I don't have tons of context on this task though, will defer to @keyvankhademi here

@yuqi88 yuqi88 mentioned this pull request Sep 29, 2023
Closed
8 tasks
@yuqi88 yuqi88 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Opeyem1a Opeyem1a Opeyem1a approved these changes

Assignees

@yuqi88 yuqi88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interface EventSet
2 participants
@yuqi88 @Opeyem1a