Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that .bundle should be added to linked_dirs #96

Closed
mattbrictson opened this issue Aug 15, 2017 · 4 comments
Closed

Explain that .bundle should be added to linked_dirs #96

mattbrictson opened this issue Aug 15, 2017 · 4 comments

Comments

@mattbrictson
Copy link
Member

As explained in #95, the bundle check behavior used by this gem depends on .bundle/config from previous deployments. If this directory is not linked, bundle check will be ineffective and a slower bundle install will be used. This unnecessarily slows down deployments.

We should add this explanation to the README.

@mattbrictson
Copy link
Member Author

Closed via #102

@allaire
Copy link

allaire commented Apr 6, 2018

@mattbrictson Quick question, I don't have .bundle in my linked_dirs. I'm using capistrano-rails and it's not in the README (but vendor/bundle is). AFAIK, bundle check is still working correctly, even though .bundle is not linked, is it because vendor/bundle is? Should I also add .bundle to be safe?

Let me know and I will update the README of capistrano-rails if that's the case!

@mattbrictson
Copy link
Member Author

@allaire Yes, I agree this should also be added to the capistrano-rails README. If you'd be willing to open a PR, that would be much appreciated!

As discussed in #95, bundle check doesn't accept the --without option, so unless .bundle/config is already present, it will check whether all of the Gemfile dependencies are satisfied, not just the production ones. So I am pretty sure linking .bundle it is necessary for check to work as intended.

@allaire
Copy link

allaire commented Apr 6, 2018

@mattbrictson Great, gonna add it quick to the README :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants