steps to add node support are not working

[bamwu]

Trying to follow the steps listed here:

https://www.cappuccino.dev/blog/2017/04/cappuccino-on-node-js.html

The npm-install script fails with several errors, beginning with:

  CXX(target) Release/obj.target/fibers/src/fibers.o
../src/fibers.cc:70:58: error: no template named 'Handle'

macOS 10.15.7
Xcode 12.2
Node 12.18.4
Cappuccino latest

[cappbot]

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

[mrcarlberg]

I googled on this error and it looks like it is something with the node module fibers not compatible with Node 12. What versions of fibers do you use?

[bamwu]

Not sure. It's something Cappuccino uses internally I guess or maybe something that one of its dependencies uses internally.

[mrcarlberg]

I believe Fibers is installed when you run the file <Your Narwhal Folder>/packages/narwhal-node/bin/npm-install. It does not say which version in the file so it would be very good to know which version is installed when you run the script?

[ivucica]

https://gist.github.com/ivucica/aef34af616d481579c2a7fffac8a449d

[email protected], node v12.19.0

[mrcarlberg]

It looks like you get fibers version 1.0.15 installed on line 10

> [email protected] install /home/myusername/projects/cappuccino/narwhal/node_modules/synchronize/node_modules/fibers

[ivucica]

True.

I just spent some more time fiddling with this and independently found synchronize is the culprit, which is obvious once you pointed out the issue.

[ivucica]

I don't do development based on Node and Javascript usually (precisely why I'm here: for Objective-J), so after half an hour of playing with it, I still don't know how to work around this PR al6x/synchronize#73 not being merged, or the updated synchronize package not being released on NPM.

I also think Cappuccino 1.0.0's starter bundle's package.json might be using some outdated syntax for specifying dependencies; it's passing a JSON array instead of a dict (and this is still true on the master branch).

[ivucica]

To install the branch used in that pull request linked above al6x/synchronize#73, edit packages/narwhal-node/bin/npm-install to use this:

npm install fibers olisto/synchronize#node12 xmldom

This installs synchronize. However, that PR scopes the package, so it's no longer synchronize; it's instead @triggi/synchronize. Edit packages/narwhal-node/bootstrap.js and edit the line mentioning // using node's require():

const sync = require('@triggi/synchronize'); // using node's require()

At this point, running jake in $CAPPUCINO_STARTER_UNPACKED/narwhal/bin/jake says:

Wed Jan 27 2021 18:58:14 GMT-0000 (GMT) [error] Could not load package 'narwhal'. TypeError: Cannot find function forEach in object [object Object].
No Jakefile found (looking for: jakefile, Jakefile, jakefile.js, Jakefile.js, jakefile.j, Jakefile.j)

However, this is beyond what I can reasonably figure out how to fix. In fact, now I'm afraid I may have broken my rhino-based install...

[daboe01]

-#new
+tools

[cappbot]

Milestone: Someday. Label: tools. What's next? A reviewer should examine this issue.

[daboe01]

@ivucica did you get it working in the meantime?

[enquora]

Is this still an issue, with current Node/npm minimum version requirements?

[daboe01]

i do not think so, because nobody else complained so far.
@mrcarlberg should we close this issue?

[ivucica]

I have not tried this since. If I try again and it’s still broken for me, I can just reopen the bug.

On Fri 7 Jan 2022 at 18:35, daboe01 ***@***.***> wrote: @ivucica <https://github.com/ivucica> did you get it working in the meantime? — Reply to this email directly, view it on GitHub <#2967 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADUTHDIZMMU4DXB4DRGQMDUU4W5ZANCNFSM4VXDVTZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Sent from Gmail Mobile

[daboe01]

+#works-for-me

[cappbot]

Milestone: Someday. Labels: #works-for-me, tools. What's next? Attempts to reproduce the problem described by this issue have failed to reveal any erroneous situation.

[cappbot]

Milestone: Someday. Labels: #works-for-me, tools. What's next? Attempts to reproduce the problem described by this issue have failed to reveal any erroneous situation.

[mrcarlberg]

Just some information if someone reads this in the future.

The current Node version is a total rework of the earlier try with a Node engine for Narwhal based on Fibers. This problem is not relevant anymore.

Anyone who wants to use the Node version should follow the install instructions on https://github.com/cappuccino/cappuccino/wiki/node