-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json marshal/unmarshal #4
Comments
do you want just to change types like below
or do you want to also add methods to marshall/unmarshall them ? |
I think it would be nice if we marshal it as This would involve implementing marshal/unmarshal methods for the type. |
The type doesnt have end as attribute right ? are we going to add another struct using the range struct just for this usage ? |
Yes, type doesn't have the end time among its fields. That was done purposefully, so we won't have to keep an eye on the consistency between the start and end time, so we don't want the end field to be added to the type.
That would be the option. Another struct that would be used just to marshal/unmarshal the period itself. |
Right now these types don't support marshal/unmarshal from/to json, but implementing this might be pretty handy in the future.
The text was updated successfully, but these errors were encountered: