Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve highlights animation on home page #37

Open
caprica opened this issue Jan 7, 2022 · 1 comment
Open

Improve highlights animation on home page #37

caprica opened this issue Jan 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@caprica
Copy link
Owner

caprica commented Jan 7, 2022

The intent of the highlights animation on the home page is to replay the animation each time the highlights change.

This was attempted in #32 making use of a "key" attribute on the outer animation.

This appeared to work.

However, after time and perhaps tab off then tab on, or some race with the highlights data request, the animation glitches out and the outer animation stays with opacity 0 and hence no highlights shown.

The PR was therefore reverted.

@caprica caprica added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 7, 2022
@caprica
Copy link
Owner Author

caprica commented May 5, 2022

After testing another fix with a slightly different implementation, eventually the same glitched condition came back again, so that attempt too was reverted.

See: #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant