Unit tests passing on both Windows and Wine #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
KtorZ
approved these changes
Nov 13, 2019
| @@ -47,6 +47,7 @@ spec = describe "API Server" $ do | |||
| res `shouldBe` Left ListenErrorOperationNotPermitted | |||
|
|
|||
| it "handles port in use" $ do | |||
| skipOnWindows "Windows permits listening on same port multiple times" | |||
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 13, 2019
1016: Unit tests passing on both Windows and Wine r=KtorZ a=rvl Relates to #703. # Overview Fixes/disables some of the last tests that were failing on Windows for Microsoft reasons. 1017: Update stylish-haskell to latest (v0.9.4.4) r=KtorZ a=rvl Updates stylish-haskell to the latest. I mistakenly thought that the latest version in a Stackage LTS would be recent and downgraded it before. To test: ``` nix-shell --run "stylish-haskell --version" ``` Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #703.
Overview
Fixes/disables some of the last tests that were failing on Windows for Microsoft reasons.