Test.Utils.Paths: Fix the test data directory for Windows and Nix #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests under either Windows or Nix, we want the test data directory to be relative to the current directory, rather than an absolute path.
|
@piotr-iohk are you able to execute the windows test on this one: https://hydra.iohk.io/build/1441738 ? |
Yes, I don't see issues with the paths any longer, the tests are running. 🎉 |
piotr-iohk
approved these changes
Dec 4, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 4, 2019
1109: Test.Utils.Paths: Fix the test data directory for Windows and Nix r=rvl a=rvl # Issue Number #703 # Overview When running tests under either Windows or Nix, we want the test data directory to be relative to the current directory, rather than an absolute path. # Comments Tests pass on Windows: - [x] `cardano-wallet-core-2019.11.18-test-unit.exe` - [x] `cardano-wallet-jormungandr-2019.11.18-test-unit.exe` - [ ] `cardano-wallet-jormungandr-2019.11.18-test-integration.exe` (_running_) - [x] `cardano-wallet-launcher-2019.11.18-test-unit.exe` - [x] `cardano-wallet-cli-2019.11.18-test-unit.exe` - [x] `bech32-2019.11.18-bech32-test.exe` - [x] `text-class-2019.11.18-test-unit.exe` Co-authored-by: Rodney Lorrimar <[email protected]>
Timed out |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 4, 2019
1109: Test.Utils.Paths: Fix the test data directory for Windows and Nix r=KtorZ a=rvl # Issue Number #703 # Overview When running tests under either Windows or Nix, we want the test data directory to be relative to the current directory, rather than an absolute path. # Comments Tests pass on Windows: - [x] `cardano-wallet-core-2019.11.18-test-unit.exe` - [x] `cardano-wallet-jormungandr-2019.11.18-test-unit.exe` - [ ] `cardano-wallet-jormungandr-2019.11.18-test-integration.exe` (_running_) - [x] `cardano-wallet-launcher-2019.11.18-test-unit.exe` - [x] `cardano-wallet-cli-2019.11.18-test-unit.exe` - [x] `bech32-2019.11.18-bech32-test.exe` - [x] `text-class-2019.11.18-test-unit.exe` Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#703
Overview
When running tests under either Windows or Nix, we want the test data directory to be relative to the current directory, rather than an absolute path.
Comments
Tests pass on Windows:
cardano-wallet-core-2019.11.18-test-unit.execardano-wallet-jormungandr-2019.11.18-test-unit.execardano-wallet-jormungandr-2019.11.18-test-integration.exe(running)cardano-wallet-launcher-2019.11.18-test-unit.execardano-wallet-cli-2019.11.18-test-unit.exebech32-2019.11.18-bech32-test.exetext-class-2019.11.18-test-unit.exe