Fix bench-db on windows #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
rvl
force-pushed
the
rvl/703/db-bench-windows
branch
2 times, most recently
from
cb2b05f to
af38c7f
Compare
KtorZ
approved these changes
Nov 8, 2019
Prevents a crash on Windows and non-UTF-8 locales on other systems.
Previous change to close database was causing this error with disk
space benchmarks, which also close the database.
db: SQLite3 returned ErrorMisuse while attempting to perform close: bad parameter or other API misuse
KtorZ
force-pushed
the
rvl/703/db-bench-windows
branch
from
af38c7f to
37a4bdc
Compare
|
@rvl not sure if you have anything to add here so not triggering bors. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 8, 2019
975: Fix bench-db on windows r=KtorZ a=rvl Relates to #703. # Overview The database benchmark was failing with: ``` cardano-wallet-core-2019.11.6-bench-db.exe: C:\users\rodney\Temp\benf0f5.db: DeleteFile "\\\\?\\C:\\users\\rodney\\Temp\\benf0f5.db": permission denied (Sharing violation.) ``` And: ``` db.exe: <stdout>: commitBuffer: invalid argument (Invalid argument) ``` It works on windows but not under wine (encoding problem). 980: Move delegation certificate declaration in a separate table r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #913 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have moved tracking of delegation "certificate" into a separate SQLite table - [x] I have adjusted `readWalletMetadata` to now pull the delegation status from the right table - [x] I have added a `putDelegationCertificate` function to insert a new row in the database when new certificates are discovered - [x] I have extended the state-machine tests accordingly, with proper tagging # Comments <!-- Additional comments or screenshots to attach if any --> ``` Cardano.Wallet.DB.Sqlite Sqlite State machine tests Sequential +++ OK, passed 400 tests: 65.8% UnsuccessfulReadTxHistory 57.8% SuccessfulReadCheckpoint 57.2% CreateThenList 55.0% TxUnsortedInputs 54.8% TxUnsortedOutputs 49.0% CreateWalletTwice 32.5% ReadTxHistoryAfterDelete 28.5% PutCheckpointTwice 27.8% UnsuccessfulReadCheckpoint 24.8% ReadMetaAfterPutCert 22.5% CreateThreeWallets 18.5% RemovePendingTxTwice 17.5% RolledBackOnce 14.2% SuccessfulReadPrivateKey 13.2% SuccessfulReadTxHistory 12.0% RemoveWalletTwice Parallel # PENDING: No reason given Sqlite State machine (RndState) Sequential state machine tests +++ OK, passed 400 tests: 65.8% UnsuccessfulReadTxHistory 57.8% SuccessfulReadCheckpoint 57.2% CreateThenList 55.0% TxUnsortedInputs 54.8% TxUnsortedOutputs 49.0% CreateWalletTwice 32.5% ReadTxHistoryAfterDelete 28.5% PutCheckpointTwice 27.8% UnsuccessfulReadCheckpoint 24.8% ReadMetaAfterPutCert 22.5% CreateThreeWallets 18.5% RemovePendingTxTwice 17.5% RolledBackOnce 14.2% SuccessfulReadPrivateKey 13.2% SuccessfulReadTxHistory 12.0% RemoveWalletTwice ``` <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: KtorZ <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #703.
Overview
The database benchmark was failing with:
And:
It works on windows but not under wine (encoding problem).