CarlaSetup.bat Fails Silently When Prerequisites Installation Fails, No Proper Error Reporting

[5archoufa]

There’s a major issue with CarlaSetup.bat where it runs InstallPrerequisites.bat, but if something goes wrong, the script fails without properly reporting the error. This makes troubleshooting incredibly difficult.

What’s Happening?

CarlaSetup.bat calls InstallPrerequisites.bat to install dependencies, including Visual Studio.
The Visual Studio installer opens, installs everything successfully, and closes.
Despite this, InstallPrerequisites.bat returns an error (Error code: 1).
CarlaSetup.bat detects this error but doesn’t explain what went wrong—it just exits.

Why This is a Problem:

The script silently fails, giving no real clues about the issue.
It incorrectly detects a failure even when Visual Studio installs successfully.
Since the script exits immediately, it stops the entire CARLA setup without allowing users to investigate or continue.

Steps to Reproduce:

Clone the CARLA repository and navigate to the setup directory.

Run CarlaSetup.bat in Powershell as an administrator.

The Visual Studio installer runs, completes successfully, and closes. CarlaSetup.bat exits with no additional information.

Expected Behavior:

From what I've understood while reading the prerequesites bat file, If Visual Studio installs successfully, the script should move on to other steps of the installation, and if an actual error happens, it should explain what went wrong instead of just exiting.

What I’ve Tried:

Running CarlaSetup.bat as Administrator → Same issue.
Manually installing Visual Studio → Same issue.
Checking %TEMP%\dd_vs_community_*.log → No errors found, meaning VS installed correctly.
Modifying the script to skip VS installation → The rest of the setup works fine.

How This Could Be Fixed:

Better Error Handling in InstallPrerequisites.bat:
Instead of just checking the exit code, verify if Visual Studio is actually installed.
Capture and log real errors if something does go wrong.

Fix How CarlaSetup.bat Handles Failures:

Don’t exit immediately—print useful debugging info instead.
Let users continue or retry instead of forcing a full stop.

My System Info:

OS: Windows 10/11 (Specify version)
CARLA Version(0.10): Branch UE5-dev, Commit bc1a703
Visual Studio Version Installed: Community 2022
Python Version: 3.11