Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Edit on Github" shows with broken URL without the config entry #8

Open
carlosperate opened this issue Dec 2, 2019 · 0 comments
Open

"Edit on Github" shows with broken URL without the config entry #8

carlosperate opened this issue Dec 2, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@carlosperate
Copy link
Owner

If the github URL has not been set in the _config.yml file the "edit on github" link should not appear if built with Jekyll, and should get the URL from the Github variable if built with GH Pages.

Right now, in GH Pages the link appears, but it is broken.
@carlosperate carlosperate added the bug Something isn't working label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carlosperate