Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style warnings #143

Open
jhlegarreta opened this issue Apr 21, 2021 · 2 comments
Open

Fix style warnings #143

jhlegarreta opened this issue Apr 21, 2021 · 2 comments
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors type:formatting Formatting needs to be fixed

Comments

@jhlegarreta
Copy link
Contributor

The carpentries style checks done by the make lesson-check-all command in this repository has uncovered a number of warnings:
https://github.com/carpentries-incubator/SDC-BIDS-dMRI/runs/2395203393?check_suite_focus=true#step:16:9

They should be addressed to be consistent with the carpentries style.
@jhlegarreta jhlegarreta added good first issue Good issue for first-time contributors type:formatting Formatting needs to be fixed labels Apr 21, 2021
@jhlegarreta
Copy link
Contributor Author

Part of these are solved in #146.

The line length warnings would be best addressed by a Markdown linter tool.

@jhlegarreta jhlegarreta mentioned this issue Apr 22, 2021
Open
@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Apr 22, 2021 •
edited
Loading

carpentries/styles#586 and carpentries/styles#587 if fixed, merged and sync'ed downstream, might leave us only with the line length ones.

@jhlegarreta jhlegarreta added the help wanted Looking for Contributors label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors type:formatting Formatting needs to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhlegarreta