Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tabs / tabset panels #148

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

astroDimitrios
Copy link
Contributor

Linked to carpentries/varnish#32 this small change adds the 'tab' and 'group-tab' admonitions/panels to the Workbench's KNOWN_DIVS so that errors aren't thrown when you build a lesson using these admonitions.

@astroDimitrios
Copy link
Contributor Author

To test the new tab and group-tab you will also need:

@ErinBecker
Copy link
Contributor

Thank you for this PR @astroDimitrios, and for the excellent description and documentation. I do see this feature being very useful, especially for our workshop setup pages (for example https://datacarpentry.org/ecology-workshop/setup-python-workshop.html), which are currently using the spoiler callout class to hide different setup options. I know @froggleston responded in Slack to let you know we'll be taking a look at this in the next couple of weeks and wanted to also jump in to say I'm excited to dig in and test this new feature!

@froggleston
Copy link
Contributor

Closed and reopened this PR to force the checks to happen (something weird happened with them in the original PR).

@froggleston froggleston merged commit e75e0a4 into carpentries:main Apr 5, 2024
12 checks passed
@astroDimitrios astroDimitrios deleted the feature/tab-admonition branch April 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants