Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinkr update updates show() arguments #156

Closed
froggleston opened this issue Jun 25, 2024 · 2 comments · Fixed by #157
Closed

tinkr update updates show() arguments #156

froggleston opened this issue Jun 25, 2024 · 2 comments · Fixed by #157

Comments

@froggleston
Copy link
Contributor

{tinkr} has been updated to include a lines argument to the show() function. As a result, tests now fail: https://github.com/carpentries/pegboard/actions/runs/9654324453/job/26628333247#step:6:286

ropensci/tinkr#108
@froggleston froggleston mentioned this issue Jun 25, 2024
Merged
@zkamvar
Copy link
Contributor

zkamvar commented Jun 25, 2024

ugh, I'm sorry about this. I forgot that our universe was using the dev version of {tinkr}.

@froggleston
Copy link
Contributor Author

No worries - I caught it as I just so happened to check through the failed workflow emails this morning! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Episode and tests for tinkr show argument changes carpentries/pegboard
2 participants
@froggleston @zkamvar