-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process workshop overview lessons #65
Comments
Note: this affects four overview lessons in DataCarpentry: The lessons marked with an asterisk (*) have contents in the
The structure of these two overview pages has a setup document with links to two setup documents based on either Python or R, which use the includes. The LibraryCarpentry organisation has one overview lesson: This one actually does have episodes, so it doesn't need any special modification. |
This will address carpentries/workbench#65 by adding fallbacks to the episodes directory criteria. I've added the other directories we expect so that when the episodes directory does not exist (in the case of overview pages), then we can check that the site directory or any of the other directories exists. I had initially attempted this by setting the config.yaml as the criteria, but I forgot that I had also copied the config.yaml over to the site/built folder, so there were a lot of failures from this one change because it was getting confused where the root of the project. Another tactic I considered was to check if `.git/` was a directory, but then I realized this wouldn't work for submodules.
The workshop pages were transitioned on Monday, so this can be closed |
One of the issues that we ran into during the transition was the fact that workshop lessons cannot be built with The Workbench because they do not contain episodes:
Created on 2023-08-07 with reprex v2.0.2
The Workbench was designed to expect episodes because all lessons should have episodes. The problem was that the workshop websites were never included in the official "list of lessons" JSON data feed (for reasons unknown). Thus, these lessons were never included in any of the testing.
The solution could be to add a sentinel "empty episode" inside the episodes folder, but this would lead to confusion for learners and instead, it would be better to allow an "overview" type of lesson which does not have a sidebar (or has a sidebar that links to the other lessons).
This requires modifications to all three packages and the lesson transition workflow
type: "overview"
keyword in config; make criteria for lesson to include fallbacks for missing folders. (Allow overview lessons sandpaper#496)_includes/
, updatetransform-lesson.R
to skip episode-specific tasks (Transform overview lessons lesson-transition#92)The text was updated successfully, but these errors were encountered: