-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account for client template compilation #2
Comments
this would be nice for roots-yaml as well. |
This is a super tough issue, because it means interfacing between two different extensions. I don't want to make this happen through other-extension-specific options in one extension, I'd much rather have a general interface for this as the solution, which is a much larger undertaking. |
You could probably make this happen in your |
The problem is that a lot of the time people want to essentially pipe the output of one extension into another. But it's not a direct pipe necessarily to the next extension in like, and it's not necessarily piping the output, sometimes you want to pipe something that roots understands through. |
my initial thought for browserify & client-templates would be to put them together, but we could do that with roots-yaml as well. Why not have an option where compilation of |
I don't think putting them together is the right answer. For your second point, I don't really understand... |
Exactly what I was getting at with my first point. For the second: Example:
Then we take those compiled files, and pipe them into |
Client templates already generates UMD wrapped files always, so that's the good news. It's the piping in part that's the challenge. |
We could have a promise within the browserify stream that waits for |
I think you'd have to dive a little deeper into the roots internals to understand how we could potentially make this happen -- that isn't possible unfortunately. |
lowest priority can't be given to roots-browserify? https://github.com/jenius/roots/blob/v3/lib/extensions.coffee#L33 |
This still is not relevant to the current issue 😕 |
hmm so there's no way currently to make browserify run last? I know that we're trying to make it accord run parallel which doesn't help either if we want to have it wait |
You can make it run last, but that does not solve the problem we're talking about. |
Well my thought was if browserify runs last, verifying that |
There's a lot more complexity than you think going on with the ordering in the compile process. While I'd be happy to review a PR if you really want to dive into this, I don't have the time to take this on myself at the moment. |
I'll dive into it and see what I can do 😄 |
just wanted to throw this in the log...
leverage roots-browserify + roots-client-templates as a singlular compiled js file would be awesome
not sure the best API for such a declaration, maybe a flag when defining the browserify extension would work? 💭
The text was updated successfully, but these errors were encountered: