From 31fcf6c2c091249d92de226623f0640ff209c6b3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carsten=20K=C3=B6nig?= <carstenkoenig92@gmail.com>
Date: Tue, 23 Apr 2024 20:48:44 +0200
Subject: [PATCH 1/2] double click to edit search results

---
 CHANGELOG.md                                          | 4 ++++
 src/components/clusterselection/EditCluster.vue       | 2 +-
 src/components/clusterselection/NewCluster.vue        | 2 +-
 src/components/indices/IndexAliases.vue               | 2 +-
 src/components/indices/IndexReindex.vue               | 2 +-
 src/components/indices/NewIndex.vue                   | 2 +-
 src/components/repositories/NewSnapshotRepository.vue | 2 +-
 src/components/rest/RestQueryExamples.vue             | 2 +-
 src/components/search/EditDocument.vue                | 2 +-
 src/components/search/SearchResult.vue                | 6 ++----
 src/components/setup/SetupInstance.vue                | 2 +-
 src/components/snapshots/NewSnapshot.vue              | 2 +-
 src/components/snapshots/RestoreSnapshot.vue          | 2 +-
 src/components/welcome/ImportBackup.vue               | 2 +-
 src/composables/components/search/EditDocument.ts     | 2 +-
 src/composables/components/search/SearchResult.ts     | 4 ----
 16 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ef6e75a7..4ed9f613 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.0.6
+
+* double click to edit search results, fixes [#225](https://github.com/cars10/elasticvue/issues/225)
+
 ## 1.0.5
 
 * adds request logging to desktop app
diff --git a/src/components/clusterselection/EditCluster.vue b/src/components/clusterselection/EditCluster.vue
index 0f6455c3..e9a94b1b 100644
--- a/src/components/clusterselection/EditCluster.vue
+++ b/src/components/clusterselection/EditCluster.vue
@@ -3,7 +3,7 @@
          :title="t('cluster_selection.edit_cluster.edit.title')"
          @click.stop="dialog = true" />
 
-  <q-dialog v-model="dialog">
+  <q-dialog v-model="dialog" transition-duration="100">
     <q-card style="min-width: 800px">
       <q-card-section class="flex justify-between">
         <h2 class="text-h6 q-my-none">
diff --git a/src/components/clusterselection/NewCluster.vue b/src/components/clusterselection/NewCluster.vue
index 654210ad..325fa5d9 100644
--- a/src/components/clusterselection/NewCluster.vue
+++ b/src/components/clusterselection/NewCluster.vue
@@ -1,7 +1,7 @@
 <template>
   <q-btn :label="t('cluster_selection.new_cluster.add_cluster')" color="primary-dark" @click="dialog = true" />
 
-  <q-dialog v-model="dialog">
+  <q-dialog v-model="dialog" transition-duration="100">
     <q-card style="min-width: 800px">
       <q-card-section class="flex justify-between">
         <h2 class="text-h6 q-my-none">{{ t('cluster_selection.new_cluster.heading') }}</h2>
diff --git a/src/components/indices/IndexAliases.vue b/src/components/indices/IndexAliases.vue
index 8840d555..42a888ec 100644
--- a/src/components/indices/IndexAliases.vue
+++ b/src/components/indices/IndexAliases.vue
@@ -8,7 +8,7 @@
     </q-item-section>
   </q-item>
 
-  <q-dialog v-model="dialog">
+  <q-dialog v-model="dialog" transition-duration="100">
     <q-card style="width: 600px; max-width: 80vw;">
       <q-card-section class="flex justify-between">
         <div class="flex">
diff --git a/src/components/indices/IndexReindex.vue b/src/components/indices/IndexReindex.vue
index 6518eed8..deb5354e 100644
--- a/src/components/indices/IndexReindex.vue
+++ b/src/components/indices/IndexReindex.vue
@@ -8,7 +8,7 @@
     </q-item-section>
   </q-item>
 
-  <q-dialog v-model="dialog">
+  <q-dialog v-model="dialog" transition-duration="100">
     <q-card style="width: 600px; max-width: 80vw;">
       <q-card-section class="flex justify-between">
         <div class="flex">
diff --git a/src/components/indices/NewIndex.vue b/src/components/indices/NewIndex.vue
index 02060611..70e55b6b 100644
--- a/src/components/indices/NewIndex.vue
+++ b/src/components/indices/NewIndex.vue
@@ -1,7 +1,7 @@
 <template>
   <q-btn id="new_index" color="primary-dark" :label="t('indices.new_index.heading')" @click="dialog = true" />
 
-  <q-dialog v-model="dialog" @hide="resetForm">
+  <q-dialog v-model="dialog" transition-duration="100" @hide="resetForm">
     <q-card style="width: 500px">
       <q-card-section class="flex justify-between">
         <h2 class="text-h6 q-my-none">
diff --git a/src/components/repositories/NewSnapshotRepository.vue b/src/components/repositories/NewSnapshotRepository.vue
index 14ba432e..c9a5e0e6 100644
--- a/src/components/repositories/NewSnapshotRepository.vue
+++ b/src/components/repositories/NewSnapshotRepository.vue
@@ -1,7 +1,7 @@
 <template>
   <q-btn color="primary-dark" :label="t('repositories.new_repository.heading')" @click="dialog = true" />
 
-  <q-dialog v-model="dialog" @hide="hide">
+  <q-dialog v-model="dialog" transition-duration="100" @hide="hide">
     <q-card style="width: 500px">
       <q-card-section class="flex justify-between">
         <h2 class="text-h6 q-my-none">
diff --git a/src/components/rest/RestQueryExamples.vue b/src/components/rest/RestQueryExamples.vue
index edc2631b..3177f343 100644
--- a/src/components/rest/RestQueryExamples.vue
+++ b/src/components/rest/RestQueryExamples.vue
@@ -2,7 +2,7 @@
   <q-btn :label="t('query.rest_query_examples.heading')" icon="info" color="dark-grey" class="q-mb-sm"
          @click="dialog = true" />
 
-  <q-dialog v-model="dialog">
+  <q-dialog v-model="dialog" transition-duration="100">
     <q-card style="min-width: 900px; max-width: 1600px;">
       <q-card-section class="flex justify-between">
         <div class="flex">
diff --git a/src/components/search/EditDocument.vue b/src/components/search/EditDocument.vue
index 57056509..ad35c6eb 100644
--- a/src/components/search/EditDocument.vue
+++ b/src/components/search/EditDocument.vue
@@ -1,5 +1,5 @@
 <template>
-  <q-dialog v-model="ownValue" @show="triggerResize">
+  <q-dialog v-model="ownValue" transition-duration="100" @show="triggerResize">
     <q-card style="width: 1000px; max-width: 1000px;">
       <q-card-section class="flex justify-between">
         <div class="flex">
diff --git a/src/components/search/SearchResult.vue b/src/components/search/SearchResult.vue
index 6135d675..c5b43e64 100644
--- a/src/components/search/SearchResult.vue
+++ b/src/components/search/SearchResult.vue
@@ -1,5 +1,5 @@
 <template>
-  <tr>
+  <tr class="clickable" title="Double click to edit" @dblclick="edit = true">
     <td>
       <slot name="checkbox" />
     </td>
@@ -8,10 +8,9 @@
       <template v-else>{{ renderValue(doc, column) }}</template>
     </td>
     <td>
+      <edit-document v-model="edit" :_id="doc._id" :_index="doc._index" :_type="doc._type" :_routing="doc._routing" />
       <div v-intersection="onIntersection" class="inline-block" style="min-width: 134px">
-        <edit-document v-model="edit" :_id="doc._id" :_index="doc._index" :_type="doc._type" :_routing="doc._routing" />
         <q-btn-group v-if="buttonsVisible">
-          <q-btn icon="info" color="dark-grey" @click="showDocument" />
           <q-btn icon="edit" color="dark-grey" @click="edit = true" />
           <q-btn icon="delete" color="dark-grey" @click="deleteDocument" />
         </q-btn-group>
@@ -31,7 +30,6 @@
   const {
     resultColumns,
     edit,
-    showDocument,
     deleteDocument,
     renderValue,
     buttonsVisible,
diff --git a/src/components/setup/SetupInstance.vue b/src/components/setup/SetupInstance.vue
index 92202911..15a8a80c 100644
--- a/src/components/setup/SetupInstance.vue
+++ b/src/components/setup/SetupInstance.vue
@@ -1,7 +1,7 @@
 <template>
   <q-btn id="add_cluster" color="primary-dark" icon="add" :label="t('setup.setup_instance.heading')" @click="dialog = true" />
 
-  <q-dialog v-model="dialog" position="top" transition-show="scale" transition-hide="scale">
+  <q-dialog v-model="dialog" position="top" transition-show="scale" transition-hide="scale" transition-duration="100">
     <q-card style="width: 1000px;max-width: 1000px" class="q-mt-xl">
       <q-card-section class="flex justify-between">
         <h2 class="text-h5 q-my-none">{{ t('setup.setup_instance.heading') }}</h2>
diff --git a/src/components/snapshots/NewSnapshot.vue b/src/components/snapshots/NewSnapshot.vue
index e6f39a77..4e2d17d2 100644
--- a/src/components/snapshots/NewSnapshot.vue
+++ b/src/components/snapshots/NewSnapshot.vue
@@ -1,7 +1,7 @@
 <template>
   <q-btn color="primary-dark" :label="t('snapshots.new_snapshot.heading')" @click="dialog = true" />
 
-  <q-dialog v-model="dialog" @hide="resetForm">
+  <q-dialog v-model="dialog" transition-duration="100" @hide="resetForm">
     <q-card style="width: 500px">
       <q-card-section class="flex justify-between">
         <h2 class="text-h6 q-my-none">
diff --git a/src/components/snapshots/RestoreSnapshot.vue b/src/components/snapshots/RestoreSnapshot.vue
index a11e360b..0ac2a323 100644
--- a/src/components/snapshots/RestoreSnapshot.vue
+++ b/src/components/snapshots/RestoreSnapshot.vue
@@ -1,7 +1,7 @@
 <template>
   <q-btn color="dark-grey" icon="restore" @click="dialog = true" />
 
-  <q-dialog v-model="dialog" @hide="resetForm">
+  <q-dialog v-model="dialog" transition-duration="100" @hide="resetForm">
     <q-card style="width: 500px">
       <q-card-section class="flex justify-between">
         <h2 class="text-h6 q-my-none">
diff --git a/src/components/welcome/ImportBackup.vue b/src/components/welcome/ImportBackup.vue
index 35c69f06..a39d2867 100644
--- a/src/components/welcome/ImportBackup.vue
+++ b/src/components/welcome/ImportBackup.vue
@@ -1,7 +1,7 @@
 <template>
   <q-btn color="primary-dark" :label="t('welcome.import_backup.heading')" icon="upload" @click="dialog = true" />
 
-  <q-dialog v-model="dialog" position="top" transition-show="scale" transition-hide="scale">
+  <q-dialog v-model="dialog" position="top" transition-show="scale" transition-hide="scale" transition-duration="100">
     <q-card style="width: 500px" class="q-mt-xl">
       <q-card-section class="flex justify-between">
         <h2 class="text-h5 q-my-none">{{ t('welcome.import_backup.heading') }}</h2>
diff --git a/src/composables/components/search/EditDocument.ts b/src/composables/components/search/EditDocument.ts
index 1f93989d..7d712a54 100644
--- a/src/composables/components/search/EditDocument.ts
+++ b/src/composables/components/search/EditDocument.ts
@@ -48,8 +48,8 @@ export const useEditDocument = (props: EditDocumentProps, emit: any) => {
 
   watch(ownValue, value => (emit('update:modelValue', value)))
   watch(() => props.modelValue, value => {
-    ownValue.value = value
     if (value) loadDocument()
+    ownValue.value = value
   })
 
   const loadDocument = async () => {
diff --git a/src/composables/components/search/SearchResult.ts b/src/composables/components/search/SearchResult.ts
index edb6ec11..ba195100 100644
--- a/src/composables/components/search/SearchResult.ts
+++ b/src/composables/components/search/SearchResult.ts
@@ -1,7 +1,6 @@
 import { useTranslation } from '../../i18n.ts'
 import { useSearchStore } from '../../../store/search.ts'
 import { computed, ref } from 'vue'
-import { useModal } from '../../Modal.ts'
 import { defineElasticsearchRequest } from '../../CallElasticsearch.ts'
 import { stringifyJson } from '../../../helpers/json/stringify.ts'
 
@@ -20,8 +19,6 @@ export const useSearchResult = (props: SearchResultProps, emit: any) => {
     id: props.doc._id,
     routing: props.doc._routing
   })
-  const { openModalWith } = useModal()
-  const showDocument = () => (openModalWith('get', docInfo()))
 
   const { run } = defineElasticsearchRequest({ emit, method: 'delete' })
   const deleteDocument = async () => {
@@ -57,7 +54,6 @@ export const useSearchResult = (props: SearchResultProps, emit: any) => {
   return {
     resultColumns,
     edit,
-    showDocument,
     deleteDocument,
     renderValue,
     buttonsVisible,

From 29e9566c5f3c384997c9528db0b537a8c8910d03 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carsten=20K=C3=B6nig?= <carstenkoenig92@gmail.com>
Date: Tue, 23 Apr 2024 20:49:46 +0200
Subject: [PATCH 2/2] bumps version to 1.0.6

---
 browser_extension/chrome/manifest.json  | 2 +-
 browser_extension/firefox/manifest.json | 2 +-
 package.json                            | 2 +-
 src-tauri/tauri.conf.json               | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/browser_extension/chrome/manifest.json b/browser_extension/chrome/manifest.json
index a2383e3c..9d8bf2c6 100644
--- a/browser_extension/chrome/manifest.json
+++ b/browser_extension/chrome/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "Elasticvue",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Elasticsearch frontend",
   "manifest_version": 3,
   "icons": {
diff --git a/browser_extension/firefox/manifest.json b/browser_extension/firefox/manifest.json
index 27a688d8..2f26fa18 100644
--- a/browser_extension/firefox/manifest.json
+++ b/browser_extension/firefox/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "Elasticvue",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Elasticsearch frontend",
   "manifest_version": 2,
   "icons": {
diff --git a/package.json b/package.json
index 67e94aec..80f0542b 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "elasticvue",
   "private": true,
-  "version": "1.0.5",
+  "version": "1.0.6",
   "scripts": {
     "dev": "vite",
     "build": "vite build",
diff --git a/src-tauri/tauri.conf.json b/src-tauri/tauri.conf.json
index c4be6830..30263b83 100644
--- a/src-tauri/tauri.conf.json
+++ b/src-tauri/tauri.conf.json
@@ -1,7 +1,7 @@
 {
   "package": {
     "productName": "elasticvue",
-    "version": "1.0.5"
+    "version": "1.0.6"
   },
   "build": {
     "distDir": "../dist",