Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe command should provide information about the layers of each Image #348

Closed
joaopapereira opened this issue Mar 9, 2022 · 1 comment · Fixed by #622
Closed

describe command should provide information about the layers of each Image #348

joaopapereira opened this issue Mar 9, 2022 · 1 comment · Fixed by #622
Assignees
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor priority/important-soon Must be staffed and worked on currently or soon

Comments

@joaopapereira
Copy link
Member

Describe the problem/challenge you have
To help with more information about the Bundle, imgpkg should provide the layer SHA for each Image, this could help to better understand what are the moving parts of the bundle and eventually help do some debugging

Describe the solution you'd like
Expected output:

Bundle SHA: sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291

Images:
  - Image: localhost:5000/test@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
    Type: Image
    Origin: index.docker.io/dkalinin/k8s-simple-app@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
    Layers:
        - Digest: sha256:8ece9ac45f2b7228b2ed95e9f407b4f0dc2ac74f93c62ff1156f24c53042ba54


  - Image: localhost:5000/test@sha256:510482df49db421542ae10142e8ce99572b23ef72675c37e92e4a12b541a3f6a
    Type: Internal
    Layers:
        - Digest: sha256:39498e8ae7157666d1f48b549ffd5fc8331e2a241c9fbd8a619522dc93b29c95

  - Image: localhost:5000/test@sha256:ecc10da4f480b1ba263d96197151d76bc787104cbcf7f1b1f42b14340b58bae7
    Type: Signature
    Annotations:
      tag: sha256-4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0.sig
    Layers:
        - Digest: sha256:04120f5a629bb41ef33ab4a54bddb0a74d46aa1984a86762ffea4663f8b137d8

Succeeded

On the yaml output it should look like:

sha: sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291
content:
  images:
    sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0:
      annotations:
        kbld.carvel.dev/id: index.docker.io/dkalinin/k8s-simple-app:latest
        kbld.carvel.dev/origins: |
          - resolved:
              tag: latest
              url: index.docker.io/dkalinin/k8s-simple-app:latest
      image: localhost:5000/test@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
      imageType: Image
      layers:
        - digest: sha256:8ece9ac45f2b7228b2ed95e9f407b4f0dc2ac74f93c62ff1156f24c53042ba54
      origin: index.docker.io/dkalinin/k8s-simple-app@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0
    sha256:510482df49db421542ae10142e8ce99572b23ef72675c37e92e4a12b541a3f6a:
      image: localhost:5000/test@sha256:510482df49db421542ae10142e8ce99572b23ef72675c37e92e4a12b541a3f6a
      imageType: Internal
      layers:
        - digest: sha256:39498e8ae7157666d1f48b549ffd5fc8331e2a241c9fbd8a619522dc93b29c95
      origin: localhost:5000/test@sha256:510482df49db421542ae10142e8ce99572b23ef72675c37e92e4a12b541a3f6a
    sha256:ecc10da4f480b1ba263d96197151d76bc787104cbcf7f1b1f42b14340b58bae7:
      annotations:
        tag: sha256-4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a9d0.sig
      image: localhost:5000/test@sha256:ecc10da4f480b1ba263d96197151d76bc787104cbcf7f1b1f42b14340b58bae7
      imageType: Signature
      layers:
        - digest: sha256:04120f5a629bb41ef33ab4a54bddb0a74d46aa1984a86762ffea4663f8b137d8
      origin: localhost:5000/test@sha256:ecc10da4f480b1ba263d96197151d76bc787104cbcf7f1b1f42b14340b58bae7
image: localhost:5000/test@sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291
metadata: {}
origin: localhost:5000/test@sha256:3cd8f0d917a92fafeef2d44eb63195d5351c35cf46b8b7448cb126c7d68c6291

Anything else you would like to add:
For the yaml output maybe we can add more information for the layers, like the mediaType and eventually annotations, this could be interesting since cosign annotates layers on the OCI Image


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help work on this issue.

@joaopapereira joaopapereira added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity carvel accepted This issue should be considered for future work and that the triage process has been completed good first issue An issue that will be a good candidate for a new contributor priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed carvel triage This issue has not yet been reviewed for validity labels Mar 9, 2022
@aaronshurley aaronshurley moved this to To Triage in Carvel Jul 25, 2022
@alexgaganashvili
Copy link

alexgaganashvili commented Dec 12, 2022

hmmm... not sure I'm getting the right digest values:
18b9b0b#diff-37c4314abe8d3d5638e91875554d7090130cfee1e88a2688a243cb88476c2dd9R180

@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
@joaopapereira joaopapereira moved this from To Triage to Unprioritized in Carvel Feb 14, 2023
@renuy renuy moved this from Unprioritized to Prioritized Backlog in Carvel Nov 2, 2023
@renuy renuy added priority/important-soon Must be staffed and worked on currently or soon and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 2, 2023
@kumaritanushree kumaritanushree self-assigned this Dec 28, 2023
@github-project-automation github-project-automation bot moved this from Prioritized Backlog to Closed in Carvel Jan 18, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Closed in Carvel Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor priority/important-soon Must be staffed and worked on currently or soon
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants