Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate a way to correlate requests made from imgpkg copy with an unique id to club them to one logical bucket #545

Closed
jhasu opened this issue Jun 27, 2023 · 2 comments · Fixed by #600
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon

Comments

@jhasu
Copy link

jhasu commented Jun 27, 2023

Describe the problem/challenge you have
Currently imgpkg in its requests don't have an unique id which can logically tie all the independent manifest and blob endpoint requests for a download session made into one logical bucket. This correlation at times is desired to correlate the requests to one download session.

Describe the solution you'd like
A unique identifier can be added to the header information to imgpkg client request which will be present in all the request made for one download session initiated by a user.

Anything else you would like to add:
[Additional information that will assist in solving the issue.]


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help work on this issue.

@jhasu jhasu added carvel triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Jun 27, 2023
@joaopapereira
Copy link
Member

joaopapereira commented Jun 29, 2023

Hey @jhasu
It could be an interesting feature that could help any registry to track what each user is retrieving or pushing into a registry at one specific time.

The request here sounds like a new header that we would include in each request to the registry that would be unique per execution of imgpkg. Not sure if there is a good HTTP header that we could piggyback on if not, maybe we can create a header called imgpkg-session-id or something similar that would contain an SHA or an OOID for each execution of imgpkg.

Do yll have any suggestions on the Header name?

Going to mark this accepted since it looks like a good feature to have.

@joaopapereira joaopapereira added carvel accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon and removed carvel triage This issue has not yet been reviewed for validity labels Jun 29, 2023
@joaopapereira joaopapereira moved this to Unprioritized in Carvel Jun 29, 2023
@jhasu
Copy link
Author

jhasu commented Jun 30, 2023

Thank you @joaopapereira.
I think "imgpkg-session-id" sounds to be an appropriate header name for this.

@renuy renuy moved this from Unprioritized to Prioritized Backlog in Carvel Aug 24, 2023
@github-project-automation github-project-automation bot moved this from Prioritized Backlog to Closed in Carvel Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants