Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kctrl package install … --dry-run --ytt-overlay-file … does not stamp out overlays #1389

Open
mamachanko opened this issue Oct 31, 2023 · 1 comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed

Comments

@mamachanko
Copy link
Contributor

What steps did you take:

I am using kctrl to stamp out package installation resources and pipe those into ytt (or kapp):

kctrl package install \
  … \
  --ytt-overlay-file overlays.yaml \
  --dry-run \
  | ytt -f -

What happened:

The overlay-related resources are not stamped out. As if --ytt-overlay-file overlays.yaml is ignored.

What did you expect:

The overlay-related resources are stamped out.

Anything else you would like to add:

The reason is that o.DryRun short-circuits before overlays are processed.

Environment:

❯ kctrl --version
kctrl version 0.48.1

Succeeded

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@mamachanko mamachanko added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Oct 31, 2023
@praveenrewar praveenrewar added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Oct 31, 2023
@praveenrewar
Copy link
Member

Thank you for reporting this issue @mamachanko!
cc @100mik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed
Projects
Status: No status
Development

No branches or pull requests

2 participants