Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying an invalid value for columns results in a stack trace #741

Open
jtigger opened this issue Apr 24, 2023 · 2 comments
Open

Specifying an invalid value for columns results in a stack trace #741

jtigger opened this issue Apr 24, 2023 · 2 comments
Assignees
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed

Comments

@jtigger
Copy link
Contributor

jtigger commented Apr 24, 2023

What steps did you take:

kapp ls -A --column id

What happened:

...
panic: Failed to find header: id

goroutine 1 [running]:
github.com/cppforlife/go-cli-ui/ui.(*ConfUI).PrintTable(0x140000f2700, {{0x10329afa1, 0x16}, {0x103287e7c, 0x4}, {0x140001e6000, 0x6, 0x6}, {0x14000709ae0, 0x2, ...}, ...})
	github.com/cppforlife/[email protected]/ui/conf_ui.go:85 +0x88
github.com/vmware-tanzu/carvel-kapp/pkg/kapp/cmd/app.(*ListOptions).Run(0x140000e3200)
	github.com/vmware-tanzu/carvel-kapp/pkg/kapp/cmd/app/list.go:156 +0x740
github.com/vmware-tanzu/carvel-kapp/pkg/kapp/cmd/app.NewListCmd.func1(0x42bd590?, {0x140007a0540?, 0x14000859260?, 0x14000811a80?})
	github.com/vmware-tanzu/carvel-kapp/pkg/kapp/cmd/app/list.go:37 +0x20
github.com/cppforlife/cobrautil.WrapRunEForCmd.func1.1(0x140000f6cf0?, {0x140007a0540, 0x0, 0x3})
	github.com/cppforlife/[email protected]/misc.go:45 +0x68
github.com/vmware-tanzu/carvel-kapp/pkg/kapp/cmd.NewKappCmd.func1.1(0x140001a3c48?, {0x140007a0540, 0x0, 0x3})
	github.com/vmware-tanzu/carvel-kapp/pkg/kapp/cmd/kapp.go:128 +0xa8
github.com/cppforlife/cobrautil.WrapRunEForCmd.func1.1(0x140000a9c00?, {0x140007a0540, 0x0, 0x3})
	github.com/cppforlife/[email protected]/misc.go:45 +0x68
github.com/cppforlife/cobrautil.WrapRunEForCmd.func1.1(0x140000a9c00?, {0x140007a0540, 0x0, 0x3})
	github.com/cppforlife/[email protected]/misc.go:45 +0x68
github.com/cppforlife/cobrautil.WrapRunEForCmd.func1.1(0x1400042b400?, {0x140007a0540, 0x0, 0x3})
	github.com/cppforlife/[email protected]/misc.go:45 +0x68
github.com/spf13/cobra.(*Command).execute(0x1400042b400, {0x140007a0510, 0x3, 0x3})
	github.com/spf13/[email protected]/command.go:856 +0x4c4
github.com/spf13/cobra.(*Command).ExecuteC(0x1400042af00)
	github.com/spf13/[email protected]/command.go:974 +0x354
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/[email protected]/command.go:902
main.nonExitingMain()
	github.com/vmware-tanzu/carvel-kapp/cmd/kapp/kapp.go:43 +0x110
main.main()
	github.com/vmware-tanzu/carvel-kapp/cmd/kapp/kapp.go:22 +0x1c

What did you expect:
An error message indicating that "id" is not a valid column. Ideally, would list the acceptable/valid values.

Anything else you would like to add:

Environment:

  • kapp version (use kapp --version): 0.54.3
  • OS (e.g. from /etc/os-release): (all)
  • Kubernetes version (use kubectl version): n/a

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@jtigger jtigger added bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been reviewed for validity labels Apr 24, 2023
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Jun 4, 2023
@praveenrewar praveenrewar removed the stale This issue has had no activity for a while and will be closed soon label Jun 7, 2023
@praveenrewar
Copy link
Member

This would require making some changes in the underlying ui library.

@praveenrewar praveenrewar added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Jun 7, 2023
@rcmadhankumar rcmadhankumar self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed
Projects
Status: No status
Development

No branches or pull requests

3 participants