Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should CI call flake8 directly, or use pre-commit? #3

Open
ajnelson-nist opened this issue Dec 19, 2022 · 2 comments
Open

Should CI call flake8 directly, or use pre-commit? #3

ajnelson-nist opened this issue Dec 19, 2022 · 2 comments

Comments

@ajnelson-nist
Copy link
Member

I noticed when reviewing #2 that flake8 is called directly as part of the Github Action.

Should this repository switch to pre-commit like some other CASE Python repos are doing?
@red-ship-it
Copy link
Collaborator

red-ship-it commented Dec 19, 2022 •
edited
Loading

Will investigate and see if it can be added as part of the pre-commit to follow other implementations.

@ajnelson-nist
Copy link
Member Author

Here's case-utils's config file for reference:

https://github.com/casework/CASE-Utilities-Python/blob/main/.pre-commit-config.yaml

The call pattern is in the GitHub Action YAML file:

https://github.com/casework/CASE-Utilities-Python/blob/main/.github/workflows/cicd.yml#L47-L50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajnelson-nist @red-ship-it