-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test workflow sometimes fails on parallelized initiation #167
Labels
Project-Bug
Something isn't working.
Milestone
Comments
ajnelson-nist
added a commit
that referenced
this issue
Nov 22, 2024
References: * #167 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
that referenced
this issue
Nov 22, 2024
References: * #167 Signed-off-by: Alex Nelson <[email protected]>
12 tasks
12 tasks
ajnelson-nist
added a commit
to casework/CASE-Corpora
that referenced
this issue
Nov 22, 2024
No effects were observed on Make-managed files. References: * casework/CASE#167 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Examples
that referenced
this issue
Nov 22, 2024
No effects were observed on Make-managed files. References: * casework/CASE#167 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/casework.github.io
that referenced
this issue
Nov 22, 2024
No effects were observed on Make-managed files. References: * casework/CASE#167 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Corpora
that referenced
this issue
Dec 19, 2024
No effects were observed on Make-managed files. References: * casework/CASE#167 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Examples
that referenced
this issue
Dec 19, 2024
No effects were observed on Make-managed files. References: * casework/CASE#167 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/casework.github.io
that referenced
this issue
Dec 19, 2024
No effects were observed on Make-managed files. References: * casework/CASE#167 Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This Issue pertains to a Make workflow matter that only occurs on fresh
git clone
s of the CASE repository, and is mitigable with a command repetition (which for some users is a 2-keystroke solution: up-arrow, return). This is not an ontology matter, so is planned to be processed without a vote, merged after the 2024-12-10 meeting.Disclaimer
Participation by NIST in the creation of the documentation of mentioned software is not intended to imply a recommendation or endorsement by the National Institute of Standards and Technology, nor is it intended to imply that any specific software is necessarily the best available for the purpose.
Bug description
A parallel execution issue is present that sometimes arises when running
make -j
(a.k.a.make --jobs
) in a fresh clone of the CASE repository, where a dependent file of the virtual environment wasn't created yet because of a missing dependency on submodule initialization.make
without-j
, which is how CASE's CI runs, has no problem because of the dependency ordering guaranteeing the dependent file (.../requirements.txt
) would exist when the dependencies are addressed in order.Steps to reproduce
This can be run in a fresh terminal, and is likely to note there is no rule to make
dependencies/UCO/requirements.txt
.Mitigation
Running
make -j
again immediately after failure (or as a sequenced second command) seems to typically end up working, as the Git submodule initialization recipe runs to completion beforemake
exits from the unsatisfied dependency. That recipe creates the file, satisfying the dependency from the first run.Resolution
Have
dependencies/UCO/requirements.txt
depend on the submodule initialization flag file (.git_submodule_init.done.log
).Coordination
develop
for the next releasedevelop
state with backwards-compatible implementation merged intodevelop-2.0.0
develop-2.0.0
(N/A)The text was updated successfully, but these errors were encountered: