Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit useful gRPC result metrics #1992

Open
ewolak-sq opened this issue Jun 22, 2021 · 0 comments
Open

Emit useful gRPC result metrics #1992

ewolak-sq opened this issue Jun 22, 2021 · 0 comments
Labels
monitoring webserver Jetty & web actions

Comments

@ewolak-sq
Copy link
Collaborator

Misk's default metrics, namely http_request_latency_ms (by action, caller, status code) are HTTP-centric. For gRPC responses, we should probably emit some gRPC-specific metrics, especially because HTTP status code in gRPC is strange (see #1983). https://github.com/grpc-ecosystem/java-grpc-prometheus might be a good place to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring webserver Jetty & web actions
Projects
None yet
Development

No branches or pull requests

2 participants