Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A metric should track WebAction registration to enable identifying unused WebActions #3377

Open
tklovett opened this issue Nov 5, 2024 · 0 comments

Comments

@tklovett
Copy link
Collaborator

tklovett commented Nov 5, 2024

Operators of older, legacy APIs may want to identify which WebActions have not had any requests in recent history. This aides in pruning unused code.

Currently, the http_request_latency_ms count metric can be used to identify WebActions (action label) that are actively used. To my knowledge, no metric exists which allows identifying unused endpoints.

I propose we add a Gauge with an action label which is incremented from zero to one during application startup for each WebAction registered/bound via WebActionModule and WebActionEntry. Each instance of the Misk application (i.e. each container, pod, server, etc.) will report the WebActions it is serving.

This will enable operators to compare the set of WebActions available to the set which is actively used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant