Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Doc disable/enable_contract_version #4591

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Update Doc disable/enable_contract_version #4591

merged 3 commits into from
Jun 10, 2024

Conversation

gRoussac
Copy link
Contributor

@gRoussac gRoussac commented Mar 6, 2024 •
edited
Loading

Change rust doc to two functions enable_contract_version disable_contract_version

In Cargo lock toml file :

  • Update "h2" to version = "0.3.26" because of audit warning on make check-rs

  • Add "itertools/use_std" in std feature of casper types to remove error

error[E0599]: no method named `unique` found for struct `std::vec::IntoIter` in the current scope
   --> /root/.cargo/git/checkouts/casper-node-dd1233ff78032163/abe4631/types/src/transaction/deploy.rs:211:53
    |
211 |         let dependencies = dependencies.into_iter().unique().collect();
    |                                                     ^^^^^^ method not found in `IntoIter<DeployHash>`

@gRoussac gRoussac linked an issue Mar 6, 2024 that may be closed by this pull request
Wrong documentation for enable_contract_version #4588
Open
ipopescu
ipopescu approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gRoussac gRoussac marked this pull request as ready for review March 6, 2024 11:32
@gRoussac gRoussac changed the title Update disable/enable_contract_version Update Doc disable/enable_contract_version Mar 8, 2024
@gRoussac gRoussac force-pushed the doc-enable-disable_contract_version branch from e97f4ae to cea4b63 Compare June 10, 2024 09:31
@gRoussac gRoussac changed the base branch from dev to feat-2.0 June 10, 2024 09:34
@gRoussac gRoussac force-pushed the doc-enable-disable_contract_version branch from 2e37487 to 787550b Compare June 10, 2024 09:37
@gRoussac gRoussac requested review from rafal-ch and alsrdn June 10, 2024 09:39
@gRoussac
Copy link
Contributor Author

bors try

casperlabs-bors-ng bot added a commit that referenced this pull request Jun 10, 2024
@casperlabs-bors-ng
Try #4591:
a5e8f07
@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

try

Build failed:

rafal-ch
rafal-ch approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gRoussac
Copy link
Contributor Author

bors try

casperlabs-bors-ng bot added a commit that referenced this pull request Jun 10, 2024
@casperlabs-bors-ng
Try #4591:
36f447b
@casperlabs-bors-ng CasperLabs bors-ng
Copy link
Contributor

try

Build failed:

@sacherjj sacherjj merged commit d15d2a1 into feat-2.0 Jun 10, 2024
1 of 2 checks passed
@gRoussac gRoussac deleted the doc-enable-disable_contract_version branch July 2, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipopescu ipopescu ipopescu approved these changes

@EdHastingsCasperAssociation EdHastingsCasperAssociation EdHastingsCasperAssociation approved these changes

@rafal-ch rafal-ch rafal-ch approved these changes

@alsrdn alsrdn Awaiting requested review from alsrdn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong documentation for enable_contract_version
5 participants
@gRoussac @ipopescu @EdHastingsCasperAssociation @rafal-ch @sacherjj