[BUG] Put transaction is expecting --transferred-value in VM1 instead of VM2 #4985
Assignees
Labels
bug
Something isn't working
Comments
EdHastingsCasperAssociation
added a commit
to EdHastingsCasperAssociation/casper-node
that referenced
this issue
Dec 9, 2024
…h-4985-transaction-vm2-settings # Conflicts: # execution_engine_testing/tests/src/test/contract_api/add_contract_version.rs # node/src/components/transaction_acceptor/tests.rs # node/src/reactor/main_reactor/tests/binary_port.rs # node/src/types/transaction/meta_transaction/meta_transaction_v1.rs # node/src/types/transaction/transaction_v1_builder.rs # node/src/utils/specimen.rs # types/src/transaction.rs
mpapierski
added a commit
to mpapierski/casper-node
that referenced
this issue
Dec 9, 2024
…gh-4985-transaction-vm2-settings Fix merge conflicts, tweak enums
mpapierski
added a commit
to mpapierski/casper-node
that referenced
this issue
Dec 10, 2024
casperlabs-bors-ng bot
added a commit
that referenced
this issue
Dec 10, 2024
4988: GH-4985: Transaction vm2 settings r=mpapierski a=mpapierski Transaction settings valid only for VM2 are stored in an enum. This solves situation when transaction target has specified extra values that will not be used by VM1 runtime. Closes #4985 5016: Fix invalid cancel_reservations args r=zajko a=wojcik91 Fix `cancel_reservations` args typing in remaining places. Co-authored-by: Michał Papierski <[email protected]> Co-authored-by: Ed Hastings <[email protected]> Co-authored-by: Michał Papierski <[email protected]> Co-authored-by: Maciej Wójcik <[email protected]>
casperlabs-bors-ng bot
added a commit
that referenced
this issue
Dec 10, 2024
4988: GH-4985: Transaction vm2 settings r=mpapierski a=mpapierski Transaction settings valid only for VM2 are stored in an enum. This solves situation when transaction target has specified extra values that will not be used by VM1 runtime. Closes #4985 Co-authored-by: Michał Papierski <[email protected]> Co-authored-by: Ed Hastings <[email protected]> Co-authored-by: Michał Papierski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Identified on the back of the put transaction issue expecting --transferred-value.
Problem with VM-specific fields: Fields like transaction_runtime are being required for all VMs, even though they are only relevant for specific VMs (e.g., VM2). This causes unnecessary complications and creates a risk of technical debt.
Impact:
For VM1, fields like transaction_runtime are irrelevant, leading to confusion and potential runtime errors.
The current structure increases complexity for developers and tools interacting with the transactions.
The text was updated successfully, but these errors were encountered: