Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regressions for fusion #2595

Closed
lintool opened this issue Sep 8, 2024 · 1 comment
Closed

Add regressions for fusion #2595

lintool opened this issue Sep 8, 2024 · 1 comment

Comments

@lintool
Copy link
Member

lintool commented Sep 8, 2024

Follow up to #2590

We've got something like:

python src/main/python/run_regression.py --index --verify --search --regression beir-v1.0.0-robust04.bge-base-en-v1.5.flat.onnx

Let's set up similar regression for fusion, using the classes just implemented in #2590

  • option (a) - we use the same script src/main/python/run_regression.py and just jam the fusion feature in there?
  • option (b) - we create a different script, like run_fusion.py for this?

I'm agnostic, but (b) seems more plausible?

Maybe something like:

src/main/python/run_fusion_regression.py --regression beir-fusion-config-file.yaml

And maybe the script already assumes you've already got the base run files in runs/... something like that?

@lintool
Copy link
Member Author

lintool commented Oct 9, 2024

#2611 merged above so we have a good start. Suggestions for improvements in #2619

Closing this issue.

@lintool lintool closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant