Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate query encoder code #1728

Closed
MXueguang opened this issue Nov 29, 2023 · 3 comments
Closed

duplicate query encoder code #1728

MXueguang opened this issue Nov 29, 2023 · 3 comments
Assignees

Comments

@MXueguang
Copy link
Member

https://github.com/castorini/pyserini/blob/master/pyserini/encode/__init__.py

https://github.com/castorini/pyserini/blob/master/pyserini/search/faiss/_searcher.py

we want to use the encoder defined in pyserini/encode

need a clean up.

@lintool
Copy link
Member

lintool commented Oct 6, 2024

I've started doing prep work for this, via #2003 and #2004 - making sure only dense retrieval models still work, updating docs there. Otherwise, we have no guardrails to check whether the refactoring is actually correct.

@lintool
Copy link
Member

lintool commented Oct 8, 2024

cf. #1812

@lintool
Copy link
Member

lintool commented Oct 12, 2024

Closed by #2008

@lintool lintool closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants