Zeds CBM duplication

[Goredell]

Describe the bug

It's possible find Zeds with multiple same CBMs installed

Steps To Reproduce

1. Find said Zed
2. ...
3. PROFIT

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.5371 (22H2)
• Game Version: fbe1583 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 2
• Game Language: []
• Mods loaded: [
  Bright Nights [bn],
  Disable NPC Needs [no_npc_food],
  Limit Fungal Growth [limit_fungal_growth],
  Item Category Overhaul [Item_Category_Overhaul],
  UDP Redux [udp_redux],
  Stats Through Skills [StatsThroughSkills],
  SpeedyDex [speedydex]
  ]

Additional context

No response

[scarf005]

i think it's intended? e.g it won't be weird to find zed with 2 battery CBMs

[chaosvolt]

With power storage it makes perfect sense, yeah. Problem is that bionic group harvest yields have no sanity-checking for duplicates, and indeed really can't be allowed to gain sanity-checking so long as the same harvest entry type is used for random scrap and power storage CBMs (since those 100% should be allowed to return the same result more than once).

The usual fix for this tends to be JSON-based, via making the dissection entry roll multiple smaller pools of bionics one time each. For example, the evolved bio-operators have a separate roll each for offensive, defensive, and utility bionics, and Bio-Weapon Apophis in Cataclysm++ does the same thing to avoid this problem.

So for husks in particular, main solutions are either to:

1. Nerf them down to only rolling to generate a single bionic.
2. Or split their bionic list into two separate ones.

[scarf005]

Or do we have JSON field that tells you whether only one can be installed? when generating loots could deduplicate CBMs based on this

[chaosvolt]

Could also work but is more effort than fixing what should be very few cases of this, since most bionic zed harvests only roll one potential power storage spawn and one potential other bionics spawn. Fairly certain evolved bio-ops and husks are the only vanilla harvest entries to roll more than one non-power-storage bionic, and as noted the former already rolls separate CBM pools to avoid this issue.