Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] Preferable adapter selection #908

Open
lars18th opened this issue Dec 16, 2021 · 3 comments
Open

[Q] Preferable adapter selection #908

lars18th opened this issue Dec 16, 2021 · 3 comments
Labels
enhancement non-spec feature requests not part of SAT>IP specification

Comments

@lars18th
Copy link
Contributor

Hi @catalinii ,

I know the functionality of the "fe=" parameter in the SAT>IP syntax. However, I want to resolve this specific sceneario:

  • I have multiple tuners attached to minisatip. And for each type I've multiple adapters available. At time the selection inside minisatip for the adapter it's based on a simple search using: the identifier (number ordering), if the tuner is free, the modulation type, etc. And what I want is to pass in the request a preferable adapter. So, if this tuner is free, then try to use this adapter; and in case if it's occupied, then search for another one free.

So, the request if it's possible to add to the request a new option called "ad=" that indicates the preference of the adapter to use. And only in case that it's in use (and the request it's for another frequency), then search like now for a free adepter.

What you think?
Regards.

@catalinii
Copy link
Owner

Hey Lars,

I am not against such option. If you want to implement I am happy to accept such PR as long as it does not impact the default functionality.

Thanks

@Jalle19 Jalle19 added enhancement non-spec feature requests not part of SAT>IP specification labels May 17, 2023
@Jalle19
Copy link
Collaborator

Jalle19 commented May 17, 2023

The way I see it this could make sense if configurable on the server (e.g. if a splitter with different attenuation on different outputs ks used and you want to prefer tuners connected to the stronger outputs), but I don't see why the client should be able to prefer adapters.

@lars18th
Copy link
Contributor Author

Hi @catalinii ,

I am not against such option. If you want to implement I am happy to accept such PR as long as it does not impact the default functionality.

The implementation is done in PR #1117 because this request is more or less very similar to #1114. Therefore as the default functionality isn't touched/modified and the code is clean/simple, then please test and merge it. 😉

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement non-spec feature requests not part of SAT>IP specification
Projects
None yet
Development

No branches or pull requests

3 participants