Allow Moodle to function as an IDP. #820
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmarsden
force-pushed
the
wip-idp
branch
2 times, most recently
from
a8479c7 to
da2d734
Compare
|
this is basically in a working state now (tested with a few different SPs) , however we still need to add some validation that a known SP is trying to use the IDP. |
|
We'd like to use this for the Matrix integration so I'm going to pick this up. Will add settings page to:
|
|
@danmarsden I have a commit ready to push. Did you want it here or in another PR? If here could I have permission to push please? |
|
cool! - looks like the EU team hadn't been added to this repo properly - I've just fixed that so hopefully you can push now? |
|
Yup, that did it, thanks. |
mark-webster-catalyst
force-pushed
the
wip-idp
branch
from
b4cc8bc to
b7b2221
Compare
* en/disable moodle as an IDP. * Whitelist services by their <saml:Issuer>
mark-webster-catalyst
force-pushed
the
wip-idp
branch
from
b7b2221 to
668670a
Compare
|
@danmarsden Rebased on MOODLE_39_STABLE and Removed WIP. Ready for review. |
mark-webster-catalyst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping this in as draft WIP code that allows Moodle to function as an IDP.
This should have a setting that turns the feature on/off and needs some further work before merging, but dropping it here in case someone else wants to pick it up and clean it up.