Add option to not track completion of reengagement

[austin-powell]

Based on my understanding of how this code works, I'm not sure that this is possible without a complete rewrite but I'll ask anyway.

Is there a reason why reengagements are forced to have activity completion turned on for them with "Show activity as complete when conditions are met"?

This causes all reengagements to get counted by Moodle's default get_course_progress_percentage function that is used (among other places) in the updated course overview block for Moodle 3.3 and on. The reason why this is an issue is that we for example have an reengagement set to occur 5 minutes after enrollment that sends a welcome email to these students. But because this reengagement then gets counted as "complete" users who have never logged in still show 4% complete on anything using core Moodle's progress functions including our custom progress reports.

Is it possible to change this or am I correct in my understanding of the plugin and its coding?

[peterbulmer]

Hi Austin,
It's been a while since I looked at the relevant code, but my recollection is that it wouldn't require a complete rewrite, and 'show activity complete' would likely have been set under the assumption that it was harmless.
If anyone wants to look into this issue don't be discouraged - it might be a minor-effort thing.

[jeremy-schweitzer]

I agree that it would be helpful to have an option to set completion as none/not tracked.

[danmarsden]

Feel free to help us work on this! - pull requests and or funding are always welcome! :-)

[ccomincini]

Good morning, I believe that the option to avoid tracking the completion of the activity would be necessary, especially considering that many users complete the courses without completing the reengagement and that moodle dashboard does not report 100% completion on the course because of the failed completion of the reengagement activity.
This is a problem and causes many support tickets are opened by users who know they have completed the course and want to see 100% completion in the dashboard.

[Lukas-Sander]

After some digging and searching, I found the code lines that need to be commented out for you to be able to select a different completion tracking (e.g. not tracking).
You need to comment out the following lines in mod_form.php:

184-187: if ($mform->elementExists('completion')) { [...]
266: $toform->completion = COMPLETION_TRACKING_AUTOMATIC;
288: $fromform->completion = COMPLETION_TRACKING_AUTOMATIC;

[Urpokarhu1]

Any progress on this fix?

[danmarsden]

@Urpokarhu1, feature development on our plugins typically requires someone to fund the time for our development team to implement the improvements. Feel free to reach out privately if this is something you are interested in or if you have internal development capabilities, pull requests are always very welcome!

[abautu]

I have faced this problem also (i.e. user completes all course modules but the course progress is missing completion the Reengagement module, and they will stay like that for the duration setting of the reengagement module).

This happens even if the "Suppress notification if target activity complete" is enabled.

I solved this issue with this #169, that makes reengagement to become completed if the user already completed the "suppress" activity.