Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll position "jumps" when clicking "Show Previous Comments" #9

Open
catamphetamine opened this issue Dec 27, 2020 · 0 comments
Open
Labels
wontfix This will not be worked on

Comments

@catamphetamine
Copy link
Owner

catamphetamine commented Dec 27, 2020

When clicking "Show Previous Comments", those previous comments get rendered, their height gets measured, and the scroll position gets adjusted so that there's no percievable "jump" of content on the page.

But, if some of those previous comments contain YouTube video links, those YouTube video links get loaded via YouTube API, and then YouTube video players are rendered in place of the links. The whole process is very fast, sometimes nearly instantaneous. But, when a link to a video gets replaced with a video player, the comment height changes, resulting in all other comments below it shifting down by that height difference, creating the "glitch" that is percieved as a "jump" of page content.

The issue appears with any type of "loadable" content (YouTube video links, Twitter links, etc).

There seems to be no solution for the issue.

The issue wouldn't exist if messaging service providers (like imageboards) did parse and load all links to "loadable" resources (like YouTube videos, Tweets, etc) right when the message is posted, so that the client application wouldn't have to do that kind of stuff in "post-processing".

@catamphetamine catamphetamine added wontfix This will not be worked on bug Something isn't working and removed bug Something isn't working labels Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant