Trustless mining #98
Open
Trustless mining #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think that before this commit the miner could recover your private key after you set the hidden service up. whoops
A really cool feature suggested by adapt-L. I'm still not certain the math checks out, not to mention the lack of any automated tests.
that's what i get for coding on my phone
makes it a bit more foolproof, as I can check if they used the right keys etc. also requires you to actually combine it with your base key before slamming it into tor and wondering why it doesn't work
|
regarding ref10 not having proper functionality, "correct" solution would be enabling trustless code only when configure flag is set to true, which could be true by default & conflict with ref10. whatever you've done here right now is probably fine for now, I can make decision later. |
|
I'll dig into this deeper when i have more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #60.
It's not really mergeable yet. The current issues are:
ed25519_impl_{pre,post}.hinmain.c, which is pretty horrible.I tried to make it somewhat idiotproof by ensuring you won't get a private key that'll work with Tor unless you did everything right. I did not protect against someone using the same base key for multiple .onions - maybe I could add a disclaimer when using
--combineif you think that's necessary.Thanks in advance for any feedback ^^