Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 Support? #143

Open
crumb1e opened this issue Jun 30, 2022 · 1 comment
Open

React 18 Support? #143

crumb1e opened this issue Jun 30, 2022 · 1 comment

Comments

@crumb1e
Copy link

crumb1e commented Jun 30, 2022

Would be good to update this package to support React 18

Expected Behavior

Successfully install into React 18 project.

Actual Behavior

Fails on install due to dependency react@^16.8.0

Steps to Reproduce (including precondition)

Create a react app with latest version of React. (e.g CRA)

Install this package.

Screenshot on This Problem (if possible)

Screenshot 2022-06-30 at 16 35 23

Your Environment

  • OS: macOS Monterey 12.2.1
  • use-intersection version: 0.2.1
@hashboard-charlie
Copy link

We switched to react-use's implementation instead of waiting here: https://streamich.github.io/react-use/?path=/story/sensors-useintersection--docs

joonassandell added a commit to joonassandell/portfolio that referenced this issue Jun 11, 2023
Copypaste and convert to js: https://github.com/cats-oss/use-intersection/blob/master/src/index.ts

Original use-intersection react dependency hasn't been updated in a while:
cats-oss/use-intersection#143

Can't use the react-use version because it's not triggering sometimes:
streamich/react-use#2359
streamich/react-use#2376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants