Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header in json file is not stored correctly #2

Open
LordRafa opened this issue Oct 19, 2024 · 1 comment
Open

Header in json file is not stored correctly #2

LordRafa opened this issue Oct 19, 2024 · 1 comment

Comments

@LordRafa
Copy link

LordRafa commented Oct 19, 2024

Hi,

The header in the json file is not store properly. It should have 80 bytes but less are stored.

Also it would be nice to have store the CRC and the original file name as it apears in the no intro dat...

@catskull
Copy link
Owner

This is the line that's doing the header stuff:

header: header[0x0100..0x014F].bytes.map {|i| i.to_s(16)}.join.upcase

I can't figure out why this wouldn't be working correctly and I don't have a good debugging setup right now. I'll look into this sometime later or if someone else wants to submit a nice PR that would be great.

The CRC thing is fine with me. I'm just as happy to provide a clean JSON romset as I am to build a UI for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants