Thm segregate

[shyaan]

please add this branch.

[kks32]

You don't need this, please pass -DCMAKE_BUILD_TYPE=Debug when compiling

[shyaan]

make "DCMAKE_BUILD_TYPE=Debug" ?

[kks32]

cmake -DCMAKE_BUILD_TYPE=Debug

[kks32]

Please don't add binary files and perf files to the code repository

[kks32]

cmake -DCMAKE_BUILD_TYPE=Debug

[kks32]

It's recommended to avoid defining using namespace please use dealii::fn to be more precise.

[kks32]

Please use lower case for namespace names

[shyaan]

Hi ,Krishna, Because I am using vscode and using a fast pull and push operation to push and pull codes, I can not control what I can push and what I can’t push. Do you have any suggestion? Thanks a lot. Best, Xiang Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10 From: Krishna Kumar<mailto:[email protected]> Sent: 2020年4月16日 18:34 To: cb-geo/thm<mailto:[email protected]> Cc: shyaan<mailto:[email protected]>; Author<mailto:[email protected]> Subject: Re: [cb-geo/thm] Thm segregate (#3) @kks32 requested changes on this pull request. Please don't add binary files and perf files to the code repository In CMakeLists.txt<#3 (comment)>:

@@ -35,6 +35,12 @@ endif()

# so we provide an option similar to BUILD_TESTING, but just for THM. option(THM_BUILD_TESTING "enable testing for thm" ON) +# Add -O0 to remove optimizations when using gcc cmake -DCMAKE_BUILD_TYPE=Debug In include/boundaryvalues.h<#3 (comment)>:

@@ -0,0 +1,137 @@

+#pragma once + +#include <fstream> +#include <iostream> + +// #include <deal.II/numerics/vector_tools.h> +#include <deal.II/base/function.h> +#include <deal.II/lac/vector.h> + +#include "globalvariables.h" + +using namespace dealii; It's recommended to avoid defining using namespace please use dealii::fn to be more precise. In include/boundaryvalues.h<#3 (comment)>:

@@ -0,0 +1,137 @@

+#pragma once + +#include <fstream> +#include <iostream> + +// #include <deal.II/numerics/vector_tools.h> +#include <deal.II/base/function.h> +#include <deal.II/lac/vector.h> + +#include "globalvariables.h" + +using namespace dealii; + +namespace EquationData { Please use lower case for namespace names ― You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AH3RE3MYFQP7WQ2UG5C2FWTRM6WZDANCNFSM4LGQ4EXA>.