Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaffeineCache should be using blocking instead of delay #739

Open
froth opened this issue Jan 31, 2023 · 1 comment
Open

CaffeineCache should be using blocking instead of delay #739

froth opened this issue Jan 31, 2023 · 1 comment

Comments

@froth
Copy link

froth commented Jan 31, 2023

Caffeine is based on ConcurrentHashMap which uses locks when writing and therefore at least the write operations can lead to blocking the current thread. Therefore from my understanding it should be wrapped in blocking instead of delay.

https://github.com/cb372/scalacache/blob/master/modules/caffeine/src/main/scala/scalacache/caffeine/CaffeineCache.scala

@kastoestoramadus
Copy link

kastoestoramadus commented Nov 28, 2023

here is written Caffeine as non-blocking:
https://blog.frankel.ch/choose-cache/2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants