Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features for v1.0.0 #3

Open
4 of 25 tasks
cbbfcd opened this issue Jul 27, 2021 · 11 comments
Open
4 of 25 tasks

features for v1.0.0 #3

cbbfcd opened this issue Jul 27, 2021 · 11 comments

Comments

@cbbfcd
Copy link
Owner

cbbfcd commented Jul 27, 2021

Inherit the original author's intention and continue to improve:

Must have

  • Support for custom Image component (ImageProgress, FastImage etc)
  • Support for lo-res thumbnail -> hi-res transition
  • Set up CI to run tests and release
  • Andorid hardware back button support
  • Gesture to close by swiping down/up
  • No dependency on navigation lib
  • No dependency on Modal
  • Improved peformance with native animation driver
  • Feature parity between Android and iOS

Really nice to have

  • Support for aspect-ratio change from thumbnail -> hi-res
  • Pinch to zoom
  • Double-tap to zoom
  • Support for gallery mode
  • Configurable Touchable component
  • Configurable transition properties
  • Configurable status bar transitioning
  • Configurable/custom header/footer

Nice to have

  • Pure JavaScript implementation
  • Integration library with react-navigation (et al)
  • Integration library with redux
  • Support Image->Video transition
  • Some form of lifecycle support (will/did open/close)

On the fence

  • Orientaion change support
  • Programmatic way of opening/closing lightbox

Not doing

  • Generic shared element transition
@cbbfcd cbbfcd changed the title features features for v1.0.0 Jul 27, 2021
@dariuscosden
Copy link

That's quite the undertaking. Would love to see this complete :D

@cbbfcd
Copy link
Owner Author

cbbfcd commented Aug 11, 2021

Welcome!

@dongdyang
Copy link

save image feature?

@cbbfcd
Copy link
Owner Author

cbbfcd commented Sep 22, 2021

If you happen to need the ability to use this warehouse, you can stay and build it together, welcome!

@demedos
Copy link

demedos commented Feb 10, 2022

Hi, thank you for keeping this library up to date.
The readme states that v0.8.9 should remove the Navigator dependency, but I don't see any branch or tag related to it. Do you have an estimated release date?

Thank you

@demedos
Copy link

demedos commented Mar 4, 2022

FYI on Android 10+ there's no need to provide a navigator, it works anyway

@cbbfcd
Copy link
Owner Author

cbbfcd commented Mar 7, 2022

FYI on Android 10+ there's no need to provide a navigator, it works anyway

thx~

@hellotreedigital
Copy link

Please Support for gallery mode

@cbbfcd
Copy link
Owner Author

cbbfcd commented May 12, 2022

Please Support for gallery mode

we can custom our gallery like in demo, but it's so good, if we can use a props, like mode: 'gallery', auto support it !

@jforaker
Copy link

jforaker commented Aug 10, 2022

Seems like orientation change should be high on the list. I wanted so bad to use this lib but the first thing i checked was a device rotation, and it wasn't pleasant. Seems like you could get most of the way there by changing out the old way:

// from this

const { width, height } = Dimensions.get('window')

// to this

const { width, height } = useWindowDimensions()

The latter is reactive instead computed once on load.

@demedos
Copy link

demedos commented Aug 11, 2022

Please note that there is still an open issue with useWindowDimensions returning swapped dimensions in some cases. See facebook/react-native#29290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants