Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Potentially rewrite update, add and getJson in utilities.py #33

Open
cbloodsworth opened this issue Apr 11, 2024 · 0 comments
Open
Assignees

Comments

@cbloodsworth
Copy link
Owner

Right now the fields on any given resume, section or entry are kind of set-in-stone: if you want to add a new field, for example an "image_preview" on the resume object, you need to manually add that to DBHelper's addNewResume, getJsonResume, and updateResume function.

These functions generally do some kind of conversion of database object to JSON or the other way around, and when copying fields from one to the other, they each are hard coded.

A solution might be to maybe pull some of the functionality into a separate method on its own, or be more strict about the way we parse json? Not sure the best solution here. Maybe we could have some list somewhere that stores all field names that we should copy over and iterate over that. I'll look at this in the future

@cbloodsworth cbloodsworth self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant