Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is subscription determined to be active before being stopped on limit reach? #51

Open
janat08 opened this issue Apr 20, 2018 · 2 comments

Comments

@janat08
Copy link
Contributor

janat08 commented Apr 20, 2018

Is subscription determined to be active before being stopped on limit reach?

I was thinking about trying to determine if subscription is being active to adjust allReady(), and start caching by pages, as well as stopping the duplication of subscriptions when they have different params.
P.S.: by requiring that users pass subscriptions in the tracker.

@paranoico
Copy link
Collaborator

Not sure, on my side we currently have not tested it yet.

@jankapunkt
Copy link
Contributor

Currently the code tries to stop the subs using stopNow when the limit overflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants