Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter NOT working correctly #65

Open
thebarty opened this issue Aug 27, 2018 · 3 comments
Open

Parameter NOT working correctly #65

thebarty opened this issue Aug 27, 2018 · 3 comments

Comments

@thebarty
Copy link

Hi guys,

there is a bug with handling constructor-parameters.

if I initiate via

export const globalSubscriptionManager = new SubsCache(
  {
    expireAfter: 11,  // Minutes to expire
    cacheLimit: -1,   // unlimited cache
    debug: Meteor.isDevelopment,
  },
)

then those parameters are not parsed correctly in the instance.

This works better in https://atmospherejs.com/blockrazor/subscache-c4 1.

@jankapunkt
Copy link
Contributor

@thebarty what do you mean by

then those parameters are not parsed correctly in the instance.

,especially "parsed correctly"?

@thebarty
Copy link
Author

Its been a while, BUT I remember that back then this package just did NOT consider the parameters. I think I debugged back then and saw that the values did NOT change - even though I passed them in the options as mentioned above.

@thebarty
Copy link
Author

Did you try it yourself? What states a

console.log(new SubsCache(
  {
    expireAfter: 11,  // Minutes to expire
    cacheLimit: -1,   // unlimited cache
    debug: Meteor.isDevelopment,
  },
))

@thebarty thebarty reopened this Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants