Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate versioning; remove hardcoded versions. #387

Open
joanimato opened this issue Feb 4, 2025 · 2 comments
Open

Automate versioning; remove hardcoded versions. #387

joanimato opened this issue Feb 4, 2025 · 2 comments

Comments

@joanimato
Copy link
Collaborator

Some files have hardcoded versions that need to be manually updated on every release.

Create a workflow that automatically updates the version number in each of these files.

@rwxayheee
Copy link
Collaborator

Hi @joanimato

I fixed the Windows binary versioning in PR #395 for Issue #390.

Now vina.exe compiled from our workflow prints:

PS C:\Users\ayhe1\Downloads\binaries-windows-2019\build\windows\release> .\vina.exe --version
AutoDock Vina v1.2.6-56-gc28e340

If you have a Windows PC, you can inspect the binaries:

Finalizing artifact upload
Artifact binaries-windows-2019.zip successfully finalized. Artifact ID 2596402870
Artifact binaries-windows-2019 has been successfully uploaded! Final size is 15117698 bytes. Artifact ID is 2596402870
Artifact download URL: https://github.com/ccsb-scripps/AutoDock-Vina/actions/runs/1334[21](https://github.com/ccsb-scripps/AutoDock-Vina/actions/runs/13342122248/job/37268081170?pr=395#step:8:22)22248/artifacts/2596402870

I don't know a good way to handle the other hard-coded versions. If you have a plan, please take over. I can look at other issues that I marked in the milestones, but if you are working on specific issues, let me know and I won't work on the same ones, so we can split the work :D

@joanimato
Copy link
Collaborator Author

@rwxayheee Yes, I have an idea of how to do the automatic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants