Overwriting AppDelegate to avoid unnecessary copy and pasting

[huttarichard]

Hi guys, great work...

I found your plugin yesterday and I take chance to little bit modify the plugin.
But I want to ask, do you want a pull request for overwritten AppDelegate method?
It will make installation much easier.

Take a look here:
https://github.com/huttarichard/cordova-facebook/tree/master/src/ios

[huttarichard]

And aslo I tested the cordova hacks you are refering to in readme, so far working all right with FacebookSDK 4. So no problem throw these changes too...

[koraybalci]

Hi there,

I skimmed your changes and they all look fine to me.

• I agree with get/set scores removal but this may break some other people's code. It was developed before graph call code, so we decided to keep it. But we can have a breaking change and kill it too, I think it will simplify the plugin and not degrade the capabilities.
• The other changes (readme + namespace + params for config) are all fine to me.
• What you have done with AppDelegate is simply neat and brilliant. I should have thought of that! I suppose you made sure it works.

That brings me to the real problem about this repo, recently I changed jobs (and countries, and continents actually). So, I have neither time to contribute nor an Apple setup (no Mac or iPhone). I hope to contribute later though.

So, what I would suggest,

• you can send a pull request, to update this repo, there are still lots of people using this plugin I supose.
• I would invite/ask you to join to this repo as a collaborator, but I couldn't figure out how to add you since the repo belongs to a team (ccsoft). Let me know if you have an idea/suggestion

Thanks again for the great work.

[huttarichard]

@koraybalci the get/set scores removal is no big deal (lets keep this if neccessary), the breaking change for me was a fix with AppDelegate and variables. I do have plans to implement this plugin to ngCordova plus write some appium tests to make sure everything working all right so, give me some time and I will do a pull request with all features.

[hirbod]

@huttarichard tried your version, you've updated the docs, but iOS 4.1.0 isn't working, as there is no FacebookSDK.framework inside of it?

[huttarichard]

@hirbod please be more specific, whats is exactly wrong? the FB sdk is there https://github.com/huttarichard/cordova-facebook/blob/master/plugin.xml#L72 https://github.com/huttarichard/cordova-facebook/tree/master/src/ios

[huttarichard]

@hirbod I just try my plugin out and it's working for me, so this is obviously about enviroment. I would love to find out whats going on ...