-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧱 include MQT Core via FetchContent instead of as a submodule #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
added
dependencies
Pull requests that update a dependency file
submodules
Pull requests that update Submodules code
github_actions
Pull requests that update Github_actions code
continuous integration
Anything related to the CI setup
c++
Anything related to C++ code
labels
Jun 20, 2024
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
This reverts commit 6b39947.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
- Coverage 96.3% 96.3% -0.1%
=======================================
Files 35 35
Lines 1818 1817 -1
Branches 224 223 -1
=======================================
- Hits 1751 1750 -1
Misses 67 67
|
The failure here will be resolved by #405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Anything related to C++ code
continuous integration
Anything related to the CI setup
dependencies
Pull requests that update a dependency file
github_actions
Pull requests that update Github_actions code
submodules
Pull requests that update Submodules code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/cda-tum/mqt-core was included as a submodule so far. This PR removes this submodule and uses the existing fetch content commands to include this dependency.
Furthermore, it adds a dependabot-like update workflow for the FetchContent-managed mqt-core dependency.
Checklist: