Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧱 include MQT Core via FetchContent instead of as a submodule #407

Merged
merged 12 commits into from
Jun 21, 2024

Conversation

burgholzer
Copy link
Member

Description

https://github.com/cda-tum/mqt-core was included as a submodule so far. This PR removes this submodule and uses the existing fetch content commands to include this dependency.

Furthermore, it adds a dependabot-like update workflow for the FetchContent-managed mqt-core dependency.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Jun 20, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code github_actions Pull requests that update Github_actions code continuous integration Anything related to the CI setup c++ Anything related to C++ code labels Jun 20, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.3%. Comparing base (015d0e6) to head (c693bcd).
Report is 53 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #407     +/-   ##
=======================================
- Coverage   96.3%   96.3%   -0.1%     
=======================================
  Files         35      35             
  Lines       1818    1817      -1     
  Branches     224     223      -1     
=======================================
- Hits        1751    1750      -1     
  Misses        67      67             
Flag Coverage Δ
cpp 96.0% <ø> (-0.1%) ⬇️
python 97.2% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer
Copy link
Member Author

The failure here will be resolved by #405

@burgholzer burgholzer enabled auto-merge (squash) June 21, 2024 15:57
@burgholzer burgholzer merged commit e190bb4 into main Jun 21, 2024
35 checks passed
@burgholzer burgholzer deleted the mqt-core-fetch-content branch June 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code submodules Pull requests that update Submodules code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant